Skip to content

Clarify documentation gaps, update examples, add warning to ensure completePurchase is being called#11601

Draft
LouiseHsu wants to merge 9 commits into
flutter:mainfrom
LouiseHsu:read-me-example-updates
Draft

Clarify documentation gaps, update examples, add warning to ensure completePurchase is being called#11601
LouiseHsu wants to merge 9 commits into
flutter:mainfrom
LouiseHsu:read-me-example-updates

Conversation

@LouiseHsu
Copy link
Copy Markdown
Contributor

@LouiseHsu LouiseHsu commented Apr 28, 2026

Fixes flutter/flutter#186377
This PR updates the README.md with lots of examples, and also adds a runtime warning when finish() hasnt been called.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • [] I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Apr 28, 2026
@LouiseHsu LouiseHsu changed the title hello Clarify documentation gaps, update examples Apr 28, 2026
@LouiseHsu LouiseHsu added the CICD Run CI/CD label May 11, 2026
@LouiseHsu LouiseHsu changed the title Clarify documentation gaps, update examples Clarify documentation gaps, update examples, add warning to ensure completePurchase is being called May 12, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label May 12, 2026
@LouiseHsu LouiseHsu added the CICD Run CI/CD label May 12, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label May 12, 2026
@LouiseHsu LouiseHsu added the CICD Run CI/CD label May 12, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label May 12, 2026
@LouiseHsu LouiseHsu added the CICD Run CI/CD label May 12, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label May 12, 2026
@LouiseHsu LouiseHsu added the CICD Run CI/CD label May 12, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label May 12, 2026
@LouiseHsu LouiseHsu added the CICD Run CI/CD label May 12, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label May 12, 2026
@LouiseHsu LouiseHsu added the CICD Run CI/CD label May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[in_app_purchase_storekit] Ensure completePurchase() will be called by developers when handling transactions

1 participant